More restricted signature matching in genstdlib.jl #13907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matching in genstdlib.jl Fix #13906
yuyichao
force-pushed
the
yyc/gendoc-match
branch
from
1b39624 to
1def889
Compare
|
Confirmed that this fixes the error. Many thanks @yuyichao ! |
yuyichao
added a commit
that referenced
this pull request
Nov 7, 2015
More restricted signature matching in genstdlib.jl
|
I suppose this is worth backporting, but not urgently, can wait until 0.4.2. |
|
This doesn't have to be backported until you see errors similar to #13906 on the 0.4 branch. (e.g. when you backport a doc improvement that triggers this). Shouldn't hurt either way though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13906
@dpsanders I verified on your branch that the error goes away. Could you confirm that?