RFC: execute finally
block after break
from try..finally in a loop (ref #12806)
#13660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
break
andcontinue
statements inside of atry
block with a labeledbreak
to thefinally
handler, followed by a conditional unlabeledbreak
, which will then be the intended loop-exit. Fixes #12806; new tests added from reworked examples there and in #1784.I'd like some feedback on one consequence. Given the following example:
On master, the loop just exits -- the
finally
block is not executed (i.e., #12806).With this patch, it is possible to
continue
afterbreak
ing to thefinally
block:(without the
continue
, we only hit finally once, as expected)