Reorganize gc.c to prepare for thread-safe variant. #10724
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nudge in the direction of making
gc.c
thread-safe. Changes are intended to be cosmetic (albeit in the ugly direction) with no functional or performance impact.HEAP(var)
that expands to(var)
. These accesses will become field accesses in the thread-safe version, at which timeHEAP
will look like#define HEAP(var) (jl_thread_heap->var)
. Unwrapped accesses are ones that are going to require more work, typically because they involve iterating over multiple instances in the thread-safe version.static
since they were unreferenced outsidegc.c
.perm_marked
was deleted because it was unreferenced.jl_gc_init()
was split out. It's the part that will do per-thread initializations in the thread-safe version.