Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vect / promote change between 1.8 and 1.9 - nightly #47261

Closed
t-bltg opened this issue Oct 20, 2022 · 2 comments
Closed

vect / promote change between 1.8 and 1.9 - nightly #47261

t-bltg opened this issue Oct 20, 2022 · 2 comments

Comments

@t-bltg
Copy link
Contributor

t-bltg commented Oct 20, 2022

Not sure if this is a bug or not (used to work in 1.8 and before), but this currently breaks Plots ci on nightly.

1.8

julia> using StaticArrays, OffsetArrays
julia> sv = SVector{10}(rand(10));
julia> ov = OffsetVector(rand(10), -2);
julia> [sv, ov]
2-element Vector{AbstractVector{Float64}}:
[...]

1.9 / nightly

julia> using StaticArrays, OffsetArrays
julia> sv = SVector{10}(rand(10));
julia> ov = OffsetVector(rand(10), -2);
julia> [sv, ov]
ERROR: DimensionMismatch: axes must agree, got (Base.OneTo(10),) and (OffsetArrays.IdOffsetRange(values=-1:8, indices=-1:8),)
Stacktrace:
  [1] _checkaxs(axd::Tuple{Base.OneTo{Int64}}, axs::Tuple{OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}}})
    @ Base ./abstractarray.jl:1168
  [2] copyto_axcheck!(dest::Vector{Float64}, src::OffsetVector{Float64, Vector{Float64}})
    @ Base ./abstractarray.jl:1171
  [3] Array
    @ ./array.jl:621 [inlined]
  [4] convert
    @ ./array.jl:613 [inlined]
  [5] setindex!
    @ ./array.jl:969 [inlined]
  [6] #109
    @ ./array.jl:408 [inlined]
  [7] afoldl
    @ ./operators.jl:536 [inlined]
  [8] getindex(::Type{Vector{Float64}}, ::SVector{10, Float64}, ::OffsetVector{Float64, Vector{Float64}})
    @ Base ./array.jl:407
  [9] vect(::SVector{10, Float64}, ::Vararg{Any})
    @ Base ./array.jl:145
 [10] top-level scope
    @ REPL[7]:1
@t-bltg t-bltg changed the title vcat change between 1.8 and 1.9 - nightly change between 1.8 and 1.9 - nightly Oct 20, 2022
@giordano
Copy link
Contributor

Can you please provide a more descriptive title? That one probably applies to a good fraction of issues opened in the last couple of months.

@t-bltg t-bltg changed the title change between 1.8 and 1.9 - nightly vect change between 1.8 and 1.9 - nightly Oct 20, 2022
@t-bltg t-bltg changed the title vect change between 1.8 and 1.9 - nightly vect / promote change between 1.8 and 1.9 - nightly Oct 20, 2022
@jishnub
Copy link
Contributor

jishnub commented Oct 21, 2022

Duplicate of #44939

@jishnub jishnub marked this as a duplicate of #44939 Oct 21, 2022
@jishnub jishnub closed this as completed Oct 21, 2022
BeastyBlacksmith added a commit to JuliaPlots/Plots.jl that referenced this issue Sep 10, 2024
* CI fixes (#4974)

* Update tests for Latexify 0.16.5

Behaviour was changed such that ã becomes \tilde{a}, instead of
\textnormal{\~{a}}.

* Test Julia 1.6 on x86 macOS instead of ARM

See: https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019

* Bump GR compat and Plots version number

* update plotly show methods for PlotlyKaleido v2

* remove Pkg

* add it back

---------

Co-authored-by: Simon Christ <[email protected]>

* Don't need to edit CI for 1.6 as no longer supported

* Don't test GR/50 on macOS

* Reorganise failing tests

 - Disabled reference tests 25 and 30, which require StatsPlots support,
   for all backends (in PlotsBase/src/examples.jl)
 - Separate tests that are skipped and tests that are known to be broken
   due to upstream issues
 - Re-enable reference test 41 as upstream issue has been fixed
   (JuliaLang/julia#47261)
 - Disable reference test 50 because of upstream issue
   (jheinen/GR.jl#550)

---------

Co-authored-by: Simon Christ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants