Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad linkage of libuv to libjulia-codegen #47198

Closed
vtjnash opened this issue Oct 17, 2022 · 0 comments · Fixed by #47203
Closed

bad linkage of libuv to libjulia-codegen #47198

vtjnash opened this issue Oct 17, 2022 · 0 comments · Fixed by #47203
Assignees
@JeffBezanson
Labels
bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies regression Regression in behavior compared to a previous version
Milestone
1.8

Comments

@vtjnash
Copy link
Member

vtjnash commented Oct 17, 2022

it is bad that libuv is getting copied into libjulia-codegen since we end up with inconsistent state

objdump -t  libjulia-codegen.so|grep 'uv_'
0000000000166959 l     F .text  0000000000000034              uv__update_time
000000000016698d l     F .text  0000000000000038              uv__basename_r
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies regression Regression in behavior compared to a previous version labels Oct 17, 2022
@vtjnash vtjnash added this to the 1.8 milestone Oct 17, 2022
vtjnash added a commit that referenced this issue Oct 17, 2022
@vtjnash
fix linkage of libuv
de0ef43 
Only libjulia-internal is supposed to be linked against this, since it
is a static library.

Fix #47198
@vtjnash vtjnash mentioned this issue Oct 17, 2022
Merged
vtjnash added a commit that referenced this issue Oct 18, 2022
@vtjnash
fix linkage of libuv (#47203)
e8aacc8 
Only libjulia-internal is supposed to be linked against this, since it
is a static library.

Fix #47198
KristofferC pushed a commit that referenced this issue Oct 27, 2022
@vtjnash
fix linkage of libuv (#47203)
7ea550d 
Only libjulia-internal is supposed to be linked against this, since it
is a static library.

Fix #47198

(cherry picked from commit e8aacc8)
KristofferC pushed a commit that referenced this issue Oct 28, 2022
@vtjnash @KristofferC
fix linkage of libuv (#47203)
0da955a 
Only libjulia-internal is supposed to be linked against this, since it
is a static library.

Fix #47198

(cherry picked from commit e8aacc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

fix linkage of libuv JuliaLang/julia
2 participants
@vtjnash @JeffBezanson