Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should be failing, since jl_dump_emitted_mi_name_fallback method is not defined #43705

Closed
vtjnash opened this issue Jan 7, 2022 · 0 comments · Fixed by #43706
Closed

CI should be failing, since jl_dump_emitted_mi_name_fallback method is not defined #43705

vtjnash opened this issue Jan 7, 2022 · 0 comments · Fixed by #43706
Assignees
@JeffBezanson
Labels
regression Regression in behavior compared to a previous version

Comments

@vtjnash
Copy link
Member

vtjnash commented Jan 7, 2022

PR #43634 (now merged) should have failed on CI, since there is no jl_dump_emitted_mi_name_fallback method defined. Why did it not fail?

Originally posted by @vtjnash in #43634 (review)
@vtjnash vtjnash added the regression Regression in behavior compared to a previous version label Jan 7, 2022
JeffBezanson added a commit that referenced this issue Jan 7, 2022
@JeffBezanson
add missing codegen fallback functions and fix test
b048043 
fixes #43705
@JeffBezanson JeffBezanson mentioned this issue Jan 7, 2022
Merged
vtjnash pushed a commit that referenced this issue Jan 10, 2022
@JeffBezanson
add missing codegen fallback functions and fix test (#43706)
07b3b22 
fixes #43705
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Feb 22, 2022
@JeffBezanson @LilithHafner
add missing codegen fallback functions and fix test (JuliaLang#43706)
ba0ccc3 
fixes JuliaLang#43705
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Mar 8, 2022
@JeffBezanson @LilithHafner
add missing codegen fallback functions and fix test (JuliaLang#43706)
f34b3bd 
fixes JuliaLang#43705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing codegen fallback functions and fix test JuliaLang/julia
2 participants
@vtjnash @JeffBezanson