-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log_record_id runtime increases quadratically with duplicate logs #28400
Comments
@StefanKarpinski I don't think you're going to get any response from Chris, he hasn't been active for half a year now |
Fair enough. I’m still giving the responsibility to him :) |
Root cause is the same as #28786 (bug introduced in #28017) Analysis: #29355 (comment) It's concerning that nobody seems to know what |
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
Log id's are useful. They are used in OhMyREPL's logger to allow repeated log messages e.g. in s loop to be overwritten. With that said because of #28786 OhMyREPL's logger also reassigned all ids to be concatenation of file name and line number. But that is fixed now. |
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
I've copied the code in question from logging.jl here:
Note that it will loop the number of times the log has previously been logged. This makes benchmarking logging very difficult, as this function takes up almost the entire runtime.
Do we even need this function? Could we just have logs not have ids unless they're explicitly provided? Where are these ids being used?
The text was updated successfully, but these errors were encountered: