Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph centrality benchmark #1163

Closed
StefanKarpinski opened this issue Aug 15, 2012 · 4 comments
Closed

graph centrality benchmark #1163

StefanKarpinski opened this issue Aug 15, 2012 · 4 comments
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster

Comments

@StefanKarpinski
Copy link
Member

See this discussion of Julia vs. Python vs. C++ performance on a graph centrality computation. We should turn this into a perf2 benchmark and make sure we get within 2x of C++. Sample code:

Sample data: http://www.udacity.com/view#Course/cs215/CourseRev/1/Unit/273003/Nugget/292002.

@JeffBezanson
Copy link
Member

The single biggest problem seems to be iterating over Sets. The way it wraps Dict iteration is probably part of it. Dict could also be better in general; ObjectIdDict is still much faster.

I also notice that strip is kind of slow, although it doesn't contribute significantly to this particular program. split is important as always.

JeffBezanson added a commit that referenced this issue Aug 16, 2012
JeffBezanson added a commit that referenced this issue Aug 16, 2012
JeffBezanson added a commit that referenced this issue Nov 16, 2012
this is an optimization and also makes it easier to get callback pointers.
closes #938. sparse on Range 3x faster
helps #1211 (ziggurat), about 25% faster
helps #1169 (game of go), about 25% faster
helps #939 (sortperm), about 25% faster
helps #1163 (graph centrality) a bit, about 10% faster
@JeffBezanson
Copy link
Member

Just noticed this is now significantly faster than it used to be.

@westonplatter
Copy link

@JeffBezanson is this issue finished? Anything remaining?

@ViralBShah
Copy link
Member

In my quick benchmarking with the codes from the gist, it appears that we are a bit faster than the C++ code, and much faster than the python code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster
Projects
None yet
Development

No branches or pull requests

4 participants