Skip to content

Commit

Permalink
Declare some LinearAlgebra types and functions to be public (#52420)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jishnub
jishnub authored Dec 7, 2023
1 parent e5046b4 commit 79de5f3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/src/LinearAlgebra.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,12 @@ export

# not exported, but public names
public AbstractTriangular,
Givens,
checksquare,
hermitian,
hermitian_type,
isbanded,
peakflops,
symmetric,
symmetric_type

Expand Down

5 comments on commit 79de5f3

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort is improved as expected, but seems like a wide range of regressions in Dict collections that are unexpected

Please sign in to comment.