Fix is_doc_expr by constraining number of args (#539)

Fix for #538
JuliaLang · Jul 24, 2022 · 75bc4fb · 75bc4fb
1 parent 7fe78fa
commit 75bc4fb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/utils.jl b/src/utils.jl
@@ -226,6 +226,7 @@ function is_doc_expr(@nospecialize(ex))
     docsym = Symbol("@doc")
     if isexpr(ex, :macrocall)
         ex::Expr
+        length(ex.args) == 4 || return false
         a = ex.args[1]
         is_global_ref(a, Core, docsym) && return true
         isa(a, Symbol) && a == docsym && return true

diff --git a/test/toplevel.jl b/test/toplevel.jl
@@ -36,6 +36,16 @@ end
     io = IOBuffer()
     show(io, @doc(Main.DocStringTest))
     @test occursin("Special", String(take!(io)))
+    # issue #538
+    @test !JuliaInterpreter.is_doc_expr(:(Core.@doc "string"))
+    ex = quote
+        @doc("no docstring")
+
+        sum
+    end
+    modexs = collect(ExprSplitter(Main, ex))
+    m, ex = first(modexs)
+    @test !JuliaInterpreter.is_doc_expr(ex.args[2])
 
     @test !isdefined(Main, :JIInvisible)
     collect(ExprSplitter(JIVisible, :(module JIInvisible f() = 1 end)))
@@ -561,4 +571,4 @@ end
         @test JuliaInterpreter.finish!(Frame(mod, ex), true) === nothing
     end
     @test length(modexs) == 2
-end
+end