Skip to content

Commit

Permalink
Fix dispatch for rdiv! with LU (#55764)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkarrasch authored Nov 1, 2024
1 parent 3de1b1d commit 4393f8c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/lu.jl
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ function ldiv!(adjA::AdjointFactorization{<:Any,<:LU{T,Tridiagonal{T,V}}}, B::Ab
return B
end

rdiv!(B::AbstractMatrix, A::LU) = transpose(ldiv!(transpose(A), transpose(B)))
rdiv!(B::AbstractMatrix, A::LU{T,Tridiagonal{T,V}}) where {T,V} = transpose(ldiv!(transpose(A), transpose(B)))

# Conversions
AbstractMatrix(F::LU) = (F.L * F.U)[invperm(F.p),:]
Expand Down
16 changes: 8 additions & 8 deletions stdlib/LinearAlgebra/src/triangular.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1048,16 +1048,16 @@ _trimul!(C::AbstractMatrix, A::AbstractTriangular, B::UpperOrLowerTriangular) =

function lmul!(A::AbstractTriangular, B::AbstractVecOrMat)
if istriu(A)
_trimul!(B, UpperTriangular(A), B)
_trimul!(B, uppertriangular(A), B)
else
_trimul!(B, LowerTriangular(A), B)
_trimul!(B, lowertriangular(A), B)
end
end
function rmul!(A::AbstractMatrix, B::AbstractTriangular)
if istriu(B)
_trimul!(A, A, UpperTriangular(B))
_trimul!(A, A, uppertriangular(B))
else
_trimul!(A, A, LowerTriangular(B))
_trimul!(A, A, lowertriangular(B))
end
end

Expand Down Expand Up @@ -1097,16 +1097,16 @@ _rdiv!(C::AbstractMatrix, A::AbstractMatrix, B::UpperOrLowerTriangular) =

function ldiv!(A::AbstractTriangular, B::AbstractVecOrMat)
if istriu(A)
_ldiv!(B, UpperTriangular(A), B)
_ldiv!(B, uppertriangular(A), B)
else
_ldiv!(B, LowerTriangular(A), B)
_ldiv!(B, lowertriangular(A), B)
end
end
function rdiv!(A::AbstractMatrix, B::AbstractTriangular)
if istriu(B)
_rdiv!(A, A, UpperTriangular(B))
_rdiv!(A, A, uppertriangular(B))
else
_rdiv!(A, A, LowerTriangular(B))
_rdiv!(A, A, lowertriangular(B))
end
end

Expand Down

0 comments on commit 4393f8c

Please sign in to comment.