Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LineEdit internal for hints #4146

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 3, 2025

Fixes JuliaLang/julia#57243

Missed this in JuliaLang/julia#57192

julia> a[1]┌ Error: Error in the keymap
│   exception =
│    UndefVarError: `check_for_hint` not defined in `REPL.LineEdit`
│    Suggestion: check for spelling errors or missing imports.
│    Stacktrace:
│     [1] getproperty
│       @ ./Base_compiler.jl:47 [inlined]
│     [2] (::REPLExt.var"#repl_init##0#repl_init##1"{REPL.LineEdit.Prompt})(::REPL.LineEdit.MIState, ::REPL.LineEditREPL, ::Vararg{Any})
│       @ REPLExt ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.12/Pkg/ext/REPLExt/REPLExt.jl:184
│     [3] #invokelatest#1
│       @ ./essentials.jl:1057 [inlined]
│     [4] invokelatest
│       @ ./essentials.jl:1053 [inlined]
│     [5] (::REPL.LineEdit.var"#match_input##0#match_input##1"{REPLExt.var"#repl_init##0#repl_init##1"{REPL.LineEdit.Prompt}, String})(s::Any, p::Any)
│       @ REPL.LineEdit ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.12/REPL/src/LineEdit.jl:1794
│     [6] macro expansion
│       @ ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.12/REPL/src/LineEdit.jl:2944 [inlined]
│     [7] macro expansion
│       @ ./lock.jl:376 [inlined]
│     [8] (::REPL.LineEdit.var"#prompt!##2#prompt!##3"{REPL.Terminals.TTYTerminal, REPL.LineEdit.ModalInterface, REPL.LineEdit.MIState, REPL.LineEdit.Prompt})()
│       @ REPL.LineEdit ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.12/REPL/src/LineEdit.jl:2933
└ @ REPL.LineEdit ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.12/REPL/src/LineEdit.jl:2946

@IanButterworth IanButterworth merged commit 7aeec76 into JuliaLang:master Feb 3, 2025
7 checks passed
@IanButterworth IanButterworth deleted the ib/hint_update branch February 3, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nightly] Keymap error using left and right arrows in REPL
1 participant