add try/catch to all callback functions (never unwind through them) #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help #196. The issue there may be that callback functions raise Julia errors sometimes (they shouldn't but stuff happens, ya know?). This wraps each one in a try/catch block and logs an "unkonwn error" message if that happens and returns from the callback with an appropriate return code to indicate error. The libcurl docs aren't super clear on these and this is hard to test so hopefully I got it right, but we'll see. Should be better.