fix: check if std::pair has less than #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraneethJain
force-pushed
the
pair-in-set
branch
from
7dc7569 to
d936a99
Compare
|
@barche this should fix JuliaIPU/IPUToolkit.jl#66 |
Also: * adds the JLCXX_FORCE_RANGES_OFF compile flag * suppresses warnings when compiling without ranges * bumps version to v0.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/JuliaInterop/CxxWrap.jl#main
std::pairdirectly has aoperator<before c++20, and since it is not treated as a container,std::setwas being applied to incompatible types. The tests weren't failing here because since c++20<=>is used to synthesizeoperator<(https://en.cppreference.com/w/cpp/utility/pair/operator_cmp)Because of this, inconsistent behavior was being observed
https://pastebin.ai/0stwtqgvry
The above program outputs different values for c++17 and c++20
This PR fixes this issue by explicitly checking if the pair types are comparable.