Use the concrete RefValue type to avoid method ambiguities #474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 1.11 there's a new
unsafe_convert(::Type{Ptr{T}}, a::GenericMemoryRef)
method which causes ambiguity errors with just Ref in theunsafe_convert()
methods we define, so now we use the concrete RefValue.This fixes ambiguity warnings from Aqua.jl, e.g:
I also renamed the
partial_nodes
field topartially_emitted_nodes
for clarity in ab0b3d5.