-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ignore by regex #385
Conversation
It would be great if we could add regex support to |
X-ref: #380 |
Thanks for poiting to #380.
The problem is that the ERROR: TOML Parser error:
none:5:21 error: unexpected start of value
output_ignorelist = [r"^PMPI_", r"^QMPI_", r"^MPIX_", r"^PMPIX_", r"^QMPIX_", r"^MPI_T_", r"^MPI_Session_"]
^
Stacktrace:
[1] parse
@ ./toml_parser.jl:441 [inlined] Thus, we cannot distinguish regexes from regular string in Please advise on the implementation ? |
Is it feasible to treat everything as regex string? |
I can not come up with an ambitious case. |
I guess I can try. Would that imply EDIT: |
Thanks! |
Amazing. Would it be possible to tag a new version so that we can add a valid |
I'm trying to generate
MPI
signatures in JuliaParallel/MPI.jl#644.It would be convenient to filter output by regex, since
output_ignorelist
requires listing everything by hand (and this would take more time than writing this PR).E.g. this works in my
generator.toml
: