BREAKING: Remove zip_open_filereader
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 98.63% 99.86% +1.22%
==========================================
Files 6 6
Lines 881 751 -130
==========================================
- Hits 869 750 -119
+ Misses 12 1 -11 ☔ View full report in Codecov by Sentry. |
nhz2
added a commit
to JuliaIO/Zarr.jl
that referenced
this pull request
Apr 1, 2024
I removed some functions from ZipArchives.jl in JuliaIO/ZipArchives.jl#43 that are not needed by Zarr.jl to reduce the complexity. No changes to Zarr.jl should be needed.
nhz2
added a commit
to nhz2/PPTX.jl
that referenced
this pull request
Apr 1, 2024
I removed some functions from ZipArchives.jl in JuliaIO/ZipArchives.jl#43 that are not needed by PPTX.jl to reduce the complexity. No changes to PPTX.jl should be needed.
meggart
pushed a commit
to JuliaIO/Zarr.jl
that referenced
this pull request
Apr 2, 2024
I removed some functions from ZipArchives.jl in JuliaIO/ZipArchives.jl#43 that are not needed by Zarr.jl to reduce the complexity. No changes to Zarr.jl should be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
zip_open_filereaderfunction and theZipFileReadertype.It also renames
ZipBufferReadertoZipReader.ZipBufferReadercan still be used as an alias forZipReader.I don't use
zip_open_filereaderbecause I found usingmmaporreadandZipBufferReaderway faster and easier.I also underestimated the maintenance cost of implementing the Julia
IOinterface. TheAbstractVector{UInt8}interface is much easier to use.This will hopefully be the last breaking change needed.