Avoid blind "using" to avoid errors on future colliding exports #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 98.10% 98.73% +0.63%
==========================================
Files 6 6
Lines 843 871 +28
==========================================
+ Hits 827 860 +33
+ Misses 16 11 -5
☔ View full report in Codecov by Sentry. |
sjkelly
reviewed
Oct 10, 2023
test/common.jl
Outdated
| @@ -0,0 +1,29 @@ | |||
| using ZipArchives: | |||
There was a problem hiding this comment.
Does it make sense to allow blind using in the tests to check exports?
Otherwise the internal changes look good to me!
There was a problem hiding this comment.
Thanks for the suggestion. Any idea what kind of errors a blind using would catch? Also, I guess I should add tests on the latest stable Julia version instead of just 1.6.
nhz2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.