use close instead of TranscodingStreams.finalize (#41)

* use close instead of finalize * remove nightly CI
JuliaIO · Mar 18, 2024 · a7f8230 · a7f8230
1 parent 7245e44
commit a7f8230
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -18,7 +18,7 @@ jobs:
         version:
           - '1.6'
           - '1'
-          - 'nightly'
+          # - 'nightly'
         os:
           - ubuntu-latest
           - macOS-13 # intel

diff --git a/Project.toml b/Project.toml
@@ -14,6 +14,6 @@ Zlib_jll = "83775a58-1f1d-513f-b197-d71354ab007a"
 ArgCheck = "2"
 CodecZlib = "0.7"
 PrecompileTools = "1"
-TranscodingStreams = "0.9, 0.10"
+TranscodingStreams = "0.10.5"
 Zlib_jll = "1"
 julia = "1.6.0"
diff --git a/src/writer.jl b/src/writer.jl
@@ -221,7 +221,7 @@ function zip_newfile(w::ZipWriter, name::AbstractString;
         throw(ArgumentError("compression_method must be Deflate or Store"))
     end
     pe.bit_flags |= level_bits
-    w.transcoder = TranscodingStream(codec, io; sharedbuf=false)
+    w.transcoder = TranscodingStream(codec, io; sharedbuf=false, stop_on_end=true)
     pe.method = real_compression_method
 
     write_local_header(io, pe)
@@ -309,7 +309,7 @@ function zip_commitfile(w::ZipWriter)
             write(transcoder, TranscodingStreams.TOKEN_END)
         finally
             # Prevent memory leak maybe.
-            TranscodingStreams.finalize(transcoder.codec)
+            close(transcoder)
         end
         cur_offset = position(w._io)
         pe.compressed_size = cur_offset - pe.offset - pe.local_header_size
@@ -357,7 +357,7 @@ function zip_abortfile(w::ZipWriter)
             write(transcoder, TranscodingStreams.TOKEN_END)
         finally
             # Prevent memory leak maybe.
-            TranscodingStreams.finalize(transcoder.codec)
+            close(transcoder)
         end
     end
     nothing