Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode doc edit backlink #164

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

LilithHafner
Copy link
Contributor

Currently, the "Edit on Github" link at https://docs.julialang.org/en/v1/stdlib/Tar/ is broken (JuliaLang/julia#50035). This PR fixes that link. See also: JuliaLang/julia#51375

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e83ed7) 97.53% compared to head (77991e4) 97.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files           4        4           
  Lines         810      810           
=======================================
  Hits          790      790           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner
Copy link
Contributor Author

Closing because @mortenpi is in the process of fixing this upstream. Sorry for the noise.

@LilithHafner
Copy link
Contributor Author

This will eventually be fixed upstream, but I don't have a timeline for when. I think it is appropriate to merge this now and revert it once the upstream fix is confirmed.

@giordano giordano merged commit d0085d8 into JuliaIO:master Jan 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants