-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #60
Fix tests #60
Conversation
MbedTLS.jl (used by HTTP.jl) uses MbedTLS v2.16.0 LibCURL.jl (used by FTPClient.jl) uses MbedTLS v2.6.1 FTPClient.jl appears to be compatible with MbedTLS v2.16.0, but HTTP.jl does not work properly with the older version.
@ibacher Tests are still failing, but I’ve unprotected master so you can merge if you want. We do need to get these tests passing though. |
Examples are still failing with:
|
@DilumAluthge: Thanks. This is going to be a bit iterative, since I don't have a local instance of MySQL to test against... |
No worries! That’s what Travis is for :) |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
===========================================
- Coverage 78.58% 67.23% -11.36%
===========================================
Files 14 14
Lines 1004 1004
===========================================
- Hits 789 675 -114
- Misses 215 329 +114
Continue to review full report at Codecov.
|
Woo hoo! |
A few fixes for the tests for this package: