Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port] Inconsistent adjacency matrix for weighted and unweighted graphs #8

Closed
gdalle opened this issue Nov 11, 2021 · 1 comment · Fixed by #42
Closed

[Port] Inconsistent adjacency matrix for weighted and unweighted graphs #8

gdalle opened this issue Nov 11, 2021 · 1 comment · Fixed by #42
Labels
bug Something isn't working

Comments

@gdalle
Copy link
Member

gdalle commented Nov 11, 2021

See sbromberger/SimpleWeightedGraphs.jl#53
@gdalle gdalle added the bug Something isn't working label Nov 11, 2021
@gdalle
Copy link
Member Author

gdalle commented Apr 6, 2023

This boils down to self-loops not being really supported, we should add a warning to the docs

gdalle added a commit that referenced this issue Apr 6, 2023
@gdalle
Add details to the docs fixing #8 and #9
344b7ee
@gdalle gdalle mentioned this issue Apr 6, 2023
Merged
@gdalle gdalle closed this as completed in #42 Apr 6, 2023
gdalle added a commit that referenced this issue Apr 6, 2023
@gdalle
Add details to the docs fixing #8 and #9 (#42)
289d729 
fix #8 and #9 by
- specifying that self-loops are not supported
- specifying that constructors from edge lists should avoid duplicate
edges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add details to the docs fixing #8 and #9 JuliaGraphs/SimpleWeightedGraphs.jl
1 participant
@gdalle