Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some tests for Julia > v1.6 #211

Conversation

simonschoelly
Copy link
Member

@simonschoelly simonschoelly commented Feb 14, 2025

This PR temporarily disables some tests on Julia > 1.6. We should aim to add them back as soon as possible. There are two different issues:

  • The visual regression tests fail. One reason is that we have to explicitly import Gtk.jl. But this is not enough - there is a second error where Gtk wants to open a display on the action runner but fails to do so.
  • A second issue is that some of the layouts rely on random generators. As the default random generator is not guaranteed to be stable between Julia versions we generate a different layout on higher Julia versions. We should fix that by using StableRNGs.jl.

@simonschoelly simonschoelly self-assigned this Feb 14, 2025
@simonschoelly simonschoelly changed the title Disable visual regression tests for Julia > v1.6 Disable some tests for Julia > v1.6 Feb 14, 2025
@simonschoelly simonschoelly merged commit 5dbab5f into JuliaGraphs:master Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant