Modify strictness of color parser (#357) #360
Conversation
- Modify white space handling - Add error message about 8-digit or 4-digit hex notation - Add support for some CSS4 notations - Add tests - Speed up parsing averagely
|
It is not difficult to implement the 8-digit or 4-digit hex notation, but we should settle the issue #353. |
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 76.23% 76.98% +0.75%
==========================================
Files 10 10
Lines 808 817 +9
==========================================
+ Hits 616 629 +13
+ Misses 192 188 -4
Continue to review full report at Codecov.
|
| @test_throws ErrorException parse(Colorant, "#FB0A") | ||
| @test_throws ErrorException parse(Colorant, "#BAD05") | ||
| @test_throws ErrorException parse(Colorant, "#BAD0007") | ||
| @test_throws ErrorException parse(Colorant, "#FFBB00AA") # not supported yet |
There was a problem hiding this comment.
In such cases is @test_broken more appropriate?
There was a problem hiding this comment.
That's right, if you (we) have already specified the correct behavior. Throwing the "not supported" error is not a broken behavior now. (Of course, checking the error message might be better.)
There was a problem hiding this comment.
I'm fine with it either way, no reason not to merge.
|
If this PR causes a problem (e.g. "not supported" error), it is probably a potential bug in the user scripts. |
|
Aww, I'm sorry but I mistook this PR number for the issue number. |
This fixes #357.