Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color scheme previews #1

Merged
merged 2 commits into from
Jan 29, 2015

Conversation

ikirill
Copy link
Contributor

@ikirill ikirill commented Jan 28, 2015

It's kind of tedious to have to select a colour scheme going by name only, so I made previews.

I could not find out how to make SVG images display properly in github's markdown, so I had to add PNG images.

Thanks for transcribing the colour schemes, they are really quite nice.

timothyrenner added a commit that referenced this pull request Jan 29, 2015
@timothyrenner timothyrenner merged commit 15503de into JuliaGraphics:master Jan 29, 2015
@timothyrenner
Copy link
Collaborator

Wow, this looks great! Thanks for doing this!

You might be able to use an HTML embed tag for the svg, but I've got no problem with the PNGs.

@ikirill
Copy link
Contributor Author

ikirill commented Jan 29, 2015

You're welcome, I use these in my visualization work. Have you thought of publishing ColorBrewer.jl like this: http://docs.julialang.org/en/latest/manual/packages/#publishing-your-package
Also, it might be worth pinging JuliaLang/Color.jl to mention this package in their readme, in a related-work kind of way, as another source of good colour schemes.

I noticed that YlOrRd is 8, not 9, elements long (the preview image is short, too). This is either a documentation bug, or the 9-long YlOrRd is missing from the json data.

@timothyrenner
Copy link
Collaborator

Thanks for pinging Color.jl and pointing out the bug. I'll open an issue and look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants