Sl/update electron #117
Merged
Sl/update electron #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it has previously been installed and the installed version doesn't match the version expected by Blink
|
Looks good, thanks! :) |
|
Great, thanks for the quick review. Do you mind if I tag a release? |
|
Not at all. |
What does this mean? |
|
Ah, okay makes sense. Thanks!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #116 and will re-install electron when electron has been previously installed and the version does not match the version expected by blink (defined in
src/AtomShell/install.jl)ref JuliaPlots/PlotlyJS.jl#175