Always call evalscripts in fill.
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(per suggestions on slack, I'm happy to move the tests into their own test specific to |
pfitzseb
requested changes
Jan 16, 2018
src/content/api.jl
Outdated
| fade ? | ||
| @js_(o, Blink.fill($sel, $html)) : | ||
| @js_ o document.querySelector($sel).innerHTML = $html | ||
| @js_(o, Blink.fill($sel, $html, $(fade ? 1 : 0))) |
There was a problem hiding this comment.
Is the fade ? 1 : 0 really necessary?
There was a problem hiding this comment.
Oops, no, it's definitely not. Thanks. I think I was worried that javascript doesn't have values for true or false, but that's silly. XD
Fixed in the rebased version i just pushed! :) thanks!
test/runtests.jl
Outdated
| @@ -13,4 +13,37 @@ w = Window(Blink.@d(:show => false)); sleep(5.0) | |||
|
|
|||
| @test sprint(Blink.jsexpr, :(Dict("a" => 1, :b => 10))) == "{\"a\":1,b:10}" | |||
|
|
|||
| @testset "content! Tests" begin | |||
There was a problem hiding this comment.
Moving this testset to test/api.jl would be great :)
There was a problem hiding this comment.
Oops! Thanks. I started rebasing this, but never finished it looks like.. Let me push that up now!
Includes a @test_throws which verifies the bug in JuliaGizmos#109. This passes before the fix: Test Summary: | Pass Total content! Tests | 7 7
NHDaly
force-pushed
the
content_api
branch
2 times, most recently
from
7104f25 to
57fc28e
Compare
Moves the fade/no-fade decision from julia down into javascript, so that more code can be reused between the two. This also simplifies the `content!` function body, which will make fixing JuliaGizmos#108 a bit easier. Updates "Fade False" test to not @test_throws. Tests still pass.
NHDaly
commented
Jan 17, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109.
Moves the fade/no-fade decision from Julia down into javascript, so that
more code can be reused whether or not
fade == true.This also simplifies the
content!function body, which will makefixing #108 a bit easier.