-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convex triangulation and vertex deletion #35
Conversation
Getting this correct is the first step towards implementing #31, since the lessons learned from fixing vertex deletion will be needed in implementing some of the algorithms there (Chew's algorithm is a basis for both). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
===========================================
- Coverage 87.73% 65.08% -22.66%
===========================================
Files 31 37 +6
Lines 2454 2818 +364
===========================================
- Hits 2153 1834 -319
- Misses 301 984 +683
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Accidentally got this branch mixed up with some other things, so once this is merged:
split_edge
,legalise_edge
)each_ghost_edge
This last part is the more difficult part, all that needs to be done is fixing the case where a boundary vertex is deleted.