Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex triangulation and vertex deletion #35

Merged
merged 11 commits into from
Mar 25, 2023
Merged

Conversation

DanielVandH
Copy link
Member

@DanielVandH DanielVandH commented Mar 22, 2023

Accidentally got this branch mixed up with some other things, so once this is merged:

  • There'll be some new operations (e.g. split_edge, legalise_edge)
  • Some new iterators like each_ghost_edge
  • A method for triangulating convex polygons
  • Deleting vertices some a triangulation

This last part is the more difficult part, all that needs to be done is fixing the case where a boundary vertex is deleted.

@DanielVandH
Copy link
Member Author

Getting this correct is the first step towards implementing #31, since the lessons learned from fixing vertex deletion will be needed in implementing some of the algorithms there (Chew's algorithm is a basis for both).

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 32.10% and project coverage change: -22.66 ⚠️

Comparison is base (ce6e5af) 87.73% compared to head (4060933) 65.08%.

❗ Current head 4060933 differs from pull request most recent head b55c002. Consider uploading reports for the commit b55c002 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   87.73%   65.08%   -22.66%     
===========================================
  Files          31       37        +6     
  Lines        2454     2818      +364     
===========================================
- Hits         2153     1834      -319     
- Misses        301      984      +683     
Impacted Files Coverage Δ
src/DelaunayTriangulation.jl 100.00% <ø> (ø)
src/data_structures/graph.jl 53.60% <0.00%> (-42.19%) ⬇️
src/operations/add_point.jl 0.00% <0.00%> (-100.00%) ⬇️
src/operations/delete_point.jl 0.00% <0.00%> (ø)
src/operations/flip_edge.jl 0.00% <0.00%> (ø)
src/operations/legalise_edge.jl 0.00% <0.00%> (ø)
src/operations/split_edge.jl 0.00% <0.00%> (ø)
src/operations/split_triangle.jl 0.00% <0.00%> (ø)
src/plotting.jl 96.34% <ø> (-2.44%) ⬇️
src/predicates/certificate.jl 78.57% <ø> (-14.29%) ⬇️
... and 10 more

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DanielVandH DanielVandH marked this pull request as ready for review March 25, 2023 13:39
@DanielVandH DanielVandH merged commit 00ce68a into main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant