Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Flux to 0.14 for package train-kernel-parameters, (keep existing compat) #522

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Flux package from 0.12, 0.13 to 0.12, 0.13, 0.14 for package train-kernel-parameters.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@theogf theogf force-pushed the compathelper/new_version/2023-07-15-01-19-38-887-03940091782 branch from 469265c to b332619 Compare July 15, 2023 01:19
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -12.53 ⚠️

Comparison is base (b7dc7a2) 79.87% compared to head (b332619) 67.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #522       +/-   ##
===========================================
- Coverage   79.87%   67.34%   -12.53%     
===========================================
  Files          52       52               
  Lines        1386     1384        -2     
===========================================
- Hits         1107      932      -175     
- Misses        279      452      +173     

see 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@theogf
Copy link
Member

theogf commented Jul 28, 2023

0.14 is correctly used, merging.

@theogf theogf merged commit 5127a26 into master Jul 28, 2023
@theogf theogf deleted the compathelper/new_version/2023-07-15-01-19-38-887-03940091782 branch July 28, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant