Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Functors to 0.4, (keep existing compat) #488

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Functors package from 0.1, 0.2, 0.3 to 0.1, 0.2, 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@theogf theogf force-pushed the compathelper/new_version/2022-11-29-01-08-56-548-01071250535 branch from bc789cf to 5ad69ca Compare November 29, 2022 01:09
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 76.35% // Head: 31.61% // Decreases project coverage by -44.73% ⚠️

Coverage data is based on head (5ad69ca) compared to base (8465c1b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #488       +/-   ##
===========================================
- Coverage   76.35%   31.61%   -44.74%     
===========================================
  Files          52       52               
  Lines        1370     1360       -10     
===========================================
- Hits         1046      430      -616     
- Misses        324      930      +606     
Impacted Files Coverage Δ
src/basekernels/sm.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/fbm.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/gabor.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/cosine.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/matern.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/constant.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/periodic.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/rational.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/nn.jl 0.00% <0.00%> (-98.00%) ⬇️
src/basekernels/wiener.jl 0.00% <0.00%> (-92.86%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing, and Functors 0.4 seems to be running, so I'm going to merge and tag

@willtebbutt willtebbutt merged commit 768207c into master Dec 3, 2022
@willtebbutt willtebbutt deleted the compathelper/new_version/2022-11-29-01-08-56-548-01071250535 branch December 3, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant