Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate definition of KernelProduct #487

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

theogf
Copy link
Member

@theogf theogf commented Nov 7, 2022

In the last PR #486 , there was a leftover issue where

(κ::KernelProduct)(x, y)

is defined twice.
This removes one of the definitions.

@theogf theogf requested a review from willtebbutt November 7, 2022 15:26
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 94.18% // Head: 71.65% // Decreases project coverage by -22.52% ⚠️

Coverage data is based on head (3823782) compared to base (8b743dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #487       +/-   ##
===========================================
- Coverage   94.18%   71.65%   -22.53%     
===========================================
  Files          52       52               
  Lines        1375     1369        -6     
===========================================
- Hits         1295      981      -314     
- Misses         80      388      +308     
Impacted Files Coverage Δ
src/kernels/kernelproduct.jl 100.00% <ø> (+3.33%) ⬆️
src/basekernels/sm.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/gabor.jl 0.00% <0.00%> (-100.00%) ⬇️
src/basekernels/nn.jl 0.00% <0.00%> (-98.00%) ⬇️
src/basekernels/wiener.jl 0.00% <0.00%> (-92.86%) ⬇️
src/basekernels/rational.jl 9.67% <0.00%> (-90.33%) ⬇️
src/basekernels/piecewisepolynomial.jl 0.00% <0.00%> (-89.48%) ⬇️
src/basekernels/exponentiated.jl 0.00% <0.00%> (-80.00%) ⬇️
src/basekernels/matern.jl 24.00% <0.00%> (-76.00%) ⬇️
src/basekernels/fbm.jl 26.66% <0.00%> (-73.34%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this

@theogf theogf merged commit 8465c1b into master Nov 7, 2022
@theogf theogf deleted the tgf/patch-kernel-product branch November 7, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants