Fixes warnings during REPL startup while using custom SYSIMG's #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are encountering following warning during Julia REPL startup if we include `KernelFunctions` in the default SYSIMG, this commit fixes that issue ``` ┌ Warning: Error requiring `PDMats` from `KernelFunctions` │ exception = │ SystemError: opening file "/home/bmharsha/.julia/packages/KernelFunctions/AxuTC/src/matrix/kernelpdmat.jl": No such file or directory │ Stacktrace: │ [1] systemerror(p::String, errno::Int32; extrainfo::Nothing) │ @ Base ./error.jl:168 │ [2] #systemerror#62 │ @ ./error.jl:167 [inlined] │ [3] systemerror │ @ ./error.jl:167 [inlined] │ [4] open(fname::String; lock::Bool, read::Nothing, write::Nothing, create::Nothing, truncate::Nothing, append::Nothing) │ @ Base ./iostream.jl:293 │ [5] open │ @ ./iostream.jl:282 [inlined] │ [6] open(f::Base.var"JuliaGaussianProcesses#326#327"{String}, args::String; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) │ @ Base ./io.jl:328 │ [7] open │ @ ./io.jl:328 [inlined] │ [8] read │ @ ./io.jl:434 [inlined] │ [9] _include(mapexpr::Function, mod::Module, _path::String) │ @ Base ./loading.jl:1166 │ [10] include(mod::Module, _path::String) │ @ Base ./Base.jl:386 │ [11] include(x::String) │ @ KernelFunctions ~/.julia/packages/KernelFunctions/AxuTC/src/KernelFunctions.jl:1 │ [12] top-level scope │ @ ~/.julia/packages/KernelFunctions/AxuTC/src/KernelFunctions.jl:124 │ [13] eval │ @ ./boot.jl:360 [inlined] │ [14] eval │ @ ~/.julia/packages/KernelFunctions/AxuTC/src/KernelFunctions.jl:1 [inlined] │ [15] (::KernelFunctions.var"JuliaGaussianProcesses#209#215")() │ @ KernelFunctions ~/.julia/packages/Requires/7Ncym/src/require.jl:99 │ [16] err(f::Any, listener::Module, modname::String) │ @ Requires ~/.julia/packages/Requires/7Ncym/src/require.jl:47 │ [17] (::KernelFunctions.var"JuliaGaussianProcesses#208#214")() │ @ KernelFunctions ~/.julia/packages/Requires/7Ncym/src/require.jl:98 │ [18] withpath(f::Any, path::String) │ @ Requires ~/.julia/packages/Requires/7Ncym/src/require.jl:37 │ [19] (::KernelFunctions.var"JuliaGaussianProcesses#207#213")() │ @ KernelFunctions ~/.julia/packages/Requires/7Ncym/src/require.jl:97 │ [20] listenpkg(f::Any, pkg::Base.PkgId) │ @ Requires ~/.julia/packages/Requires/7Ncym/src/require.jl:20 │ [21] macro expansion │ @ ~/.julia/packages/Requires/7Ncym/src/require.jl:95 [inlined] │ [22] __init__() │ @ KernelFunctions ~/.julia/packages/KernelFunctions/AxuTC/src/KernelFunctions.jl:123 └ @ Requires ~/.julia/packages/Requires/7Ncym/src/require.jl:49 ```
|
I'm happy with the change to |
Yes, it does work under Windows, here is an examples where https://github.com/FluxML/Zygote.jl/blob/master/src/Zygote.jl#L68 |
|
I ran |
|
I am surprised that/if this is needed. Requires should replace all occurrences of |
Could it be that the issue isn't @bmharsha can you share a minimal setup for how to reproduce the warning message you encounter? |
Sure, here are the minimal steps required to reproduce the issue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encounter following warning during Julia REPL startup if we include
KernelFunctionsin the default SYSIMG, this commit fixes that issue