Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm doc #35

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Update ROCm doc #35

merged 3 commits into from
Aug 8, 2023

Conversation

luraess
Copy link
Contributor

@luraess luraess commented Aug 5, 2023

This PR updates the ROCm doc to match the style and content of the CUDA page from the website, namely:

  • update content
  • add preliminary perf comparison between AMDGPU and HIP C++ for two simple kernels

@luraess luraess marked this pull request as ready for review August 5, 2023 20:29
@luraess
Copy link
Contributor Author

luraess commented Aug 5, 2023

@pxl-th you may want to verify the content as well.

@pxl-th
Copy link
Member

pxl-th commented Aug 6, 2023

Looks good to me! Thanks!

@maleadt maleadt merged commit 98ec60d into JuliaGPU:master Aug 8, 2023
@maleadt
Copy link
Member

maleadt commented Aug 8, 2023

Did you try this change locally?

image

maleadt added a commit that referenced this pull request Aug 8, 2023
@maleadt maleadt mentioned this pull request Aug 8, 2023
maleadt added a commit that referenced this pull request Aug 8, 2023
@luraess
Copy link
Contributor Author

luraess commented Aug 8, 2023

The html ~~ are missing. Fixing this now.

@luraess luraess mentioned this pull request Aug 8, 2023
@luraess
Copy link
Contributor Author

luraess commented Aug 8, 2023

@maleadt #37 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants