adjust concrete_eval_eligible overload to v1.10
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
==========================================
- Coverage 81.13% 73.27% -7.87%
==========================================
Files 23 23
Lines 3075 3046 -29
==========================================
- Hits 2495 2232 -263
- Misses 580 814 +234
☔ View full report in Codecov by Sentry. |
vtjnash
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Aug 1, 2023
This commit introduces several fixes related to the overlay method and its semi-concrete evaluation. When `f` is being overlayed, semi-concrete interpretation is performed on `f`. While this isn't problematic in itself, the issue arises since there is no overlay check within concrete evaluation in the semi-concrete interpretation (`concrete_eval_invoke`), potentially leading to mis-compilation. This commit makes adjustments to allow semi-concrete interpretation for overlay methods, while preventing the concretization of overlay methods within `concrete_eval_invoke`. Note: Confirmed GPUCompiler test suite passes with this patch after JuliaGPU/GPUCompiler.jl#488.
|
Thanks! We won't be able to test this on CI though, because of #489. As you confirmed that this works, let's just merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.