Skip to content

Commit

Permalink
Merge pull request #183 from JuliaGPU/vc/gcn2
Browse files Browse the repository at this point in the history
[GCN] Make sure we are not breaking the interface
  • Loading branch information
vchuravy authored May 6, 2021
2 parents 4dd7c7b + d58c3a7 commit 42a952d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/gcn.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Base.@kwdef struct GCNCompilerTarget <: AbstractCompilerTarget
dev_isa::String
features::String=""
end
GCNCompilerTarget(dev_isa; features="") = GCNCompilerTarget(dev_isa, features)

llvm_triple(::GCNCompilerTarget) = "amdgcn-amd-amdhsa"

Expand Down
2 changes: 2 additions & 0 deletions test/gcn.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@testset "GCN" begin

@test GCNCompilerTarget(dev_isa="gfx900") == GCNCompilerTarget("gfx900")

include("definitions/gcn.jl")

############################################################################################
Expand Down

2 comments on commit 42a952d

@vchuravy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/36221

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.5 -m "<description of version>" 42a952d76e82c09165fc361c2264ec2e95c230c7
git push origin v0.11.5

Please sign in to comment.