-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CUTENSOR 1.6 and cuQuantum 22.07 #1623
Conversation
Yeah sure I can take over! |
Codecov ReportBase: 74.39% // Head: 70.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
- Coverage 74.39% 70.59% -3.80%
==========================================
Files 131 131
Lines 10141 9665 -476
==========================================
- Hits 7544 6823 -721
- Misses 2597 2842 +245
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks! Note that #1624 changed where files are, so this will need a rebase. |
@kshyatt could you finish this? I only wanted to update CUTENSOR, but cuQuantum throws a fit then (version mismatch errors) so needs to be updated too. There's been many changes between the 0.1 versions you created wrappers for, and the 1.0 versions of CUSTATEVEC and CUTENSORNET. I already fixed CUSTATEVEC, but CUTENSORNET fails with an API error:
Release notes here: https://docs.nvidia.com/cuda/cuquantum/cutensornet/release_notes.html#cutensornet-v1-1-1. One change that still needs to happen is the workspace changes, https://docs.nvidia.com/cuda/cuquantum/cutensornet/getting_started.html#create-workspace-descriptor-and-allocate-workspace-memory; I already updated the wrappers (so it should error), but that code only gets invoked after the above API error, so something else is up.