Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CUTENSOR 1.6 and cuQuantum 22.07 #1623

Closed
wants to merge 9 commits into from
Closed

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 11, 2022

@kshyatt could you finish this? I only wanted to update CUTENSOR, but cuQuantum throws a fit then (version mismatch errors) so needs to be updated too. There's been many changes between the 0.1 versions you created wrappers for, and the 1.0 versions of CUSTATEVEC and CUTENSORNET. I already fixed CUSTATEVEC, but CUTENSORNET fails with an API error:

[2022-10-11 13:14:52][cuTENSORNet][57010][Error][cutensornetContractionOptimize] No valid path could be found with specified constraints.
tuning = NoAutoTune(): Error During Test at /home/tim/Julia/pkg/CUDA/lib/cutensornet/test/runtests.jl:30
  Got exception outside of a @test
  CUTENSORNETError: all hyper samples failed for one or more errors (enable LOGs via export CUTENSORNET_LOG_LEVEL= > 1 for details). (code 24, CUTENSORNET_STATUS_ALL_HYPER_SAMPLES_FAILED)
  Stacktrace:
    [1] throw_api_error(res::CUTENSORNET.cutensornetStatus_t)
      @ CUTENSORNET ~/Julia/pkg/CUDA/lib/cutensornet/src/error.jl:61
    [2] macro expansion
      @ ~/Julia/pkg/CUDA/lib/cutensornet/src/error.jl:74 [inlined]
    [3] cutensornetContractionOptimize(handle::Ptr{Nothing}, descNet::CUTENSORNET.CuTensorNetworkDescriptor, optimizerConfig::CUTENSORNET.CuTensorNetworkContractionOptimizerConfig, workspaceSizeConstraint::Int64, optimizerInfo::CUTENSORNET.CuTensorNetworkContractionOptimizerInfo)
      @ CUTENSORNET ~/Julia/pkg/CUDA/lib/utils/call.jl:26
    [4] rehearse_contraction(tn::CuTensorNetwork{Float32}, max_workspace_size::Int64, optimizer_conf::CUTENSORNET.OptimizerConfig)
      @ CUTENSORNET ~/Julia/pkg/CUDA/lib/cutensornet/src/tensornet.jl:7
    [5] rehearse_contraction(tn::CuTensorNetwork{Float32}, max_workspace_size::Int64)
      @ CUTENSORNET ~/Julia/pkg/CUDA/lib/cutensornet/src/tensornet.jl:3

Release notes here: https://docs.nvidia.com/cuda/cuquantum/cutensornet/release_notes.html#cutensornet-v1-1-1. One change that still needs to happen is the workspace changes, https://docs.nvidia.com/cuda/cuquantum/cutensornet/getting_started.html#create-workspace-descriptor-and-allocate-workspace-memory; I already updated the wrappers (so it should error), but that code only gets invoked after the above API error, so something else is up.

@maleadt maleadt added the installation CUDA is easy to install, right? label Oct 11, 2022
@maleadt maleadt changed the title Update to CUTENSOR 1.6. Update to CUTENSOR 1.6 and cuQuanty 22.07 Oct 11, 2022
@kshyatt
Copy link
Contributor

kshyatt commented Oct 11, 2022

Yeah sure I can take over!

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 74.39% // Head: 70.59% // Decreases project coverage by -3.79% ⚠️

Coverage data is based on head (94c3f1a) compared to base (ebba936).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
- Coverage   74.39%   70.59%   -3.80%     
==========================================
  Files         131      131              
  Lines       10141     9665     -476     
==========================================
- Hits         7544     6823     -721     
- Misses       2597     2842     +245     
Impacted Files Coverage Δ
lib/custatevec/src/CUSTATEVEC.jl 0.00% <ø> (ø)
lib/custatevec/src/error.jl 0.00% <0.00%> (ø)
lib/custatevec/src/libcustatevec.jl 0.00% <0.00%> (ø)
lib/custatevec/src/statevec.jl 0.00% <0.00%> (ø)
lib/custatevec/src/types.jl 0.00% <0.00%> (ø)
lib/cutensornet/src/CUTENSORNET.jl 0.00% <ø> (ø)
lib/cutensornet/src/error.jl 0.00% <0.00%> (ø)
lib/cutensornet/src/libcutensornet.jl 0.00% <0.00%> (ø)
lib/cutensornet/src/tensornet.jl 0.00% <ø> (ø)
lib/cutensornet/src/types.jl 0.00% <0.00%> (ø)
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt
Copy link
Member Author

maleadt commented Oct 12, 2022

Thanks! Note that #1624 changed where files are, so this will need a rebase.

@maleadt maleadt changed the title Update to CUTENSOR 1.6 and cuQuanty 22.07 Update to CUTENSOR 1.6 and cuQuantum 22.07 Oct 20, 2022
This was referenced Oct 21, 2022
@maleadt
Copy link
Member Author

maleadt commented Oct 21, 2022

Superseded by #1636 #1638 #1639.

@maleadt maleadt closed this Oct 21, 2022
@maleadt maleadt deleted the tb/cutensor branch June 13, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation CUDA is easy to install, right?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants