Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added line to rabbit_fox_hawk.jl to make animation run and fix #1118 #1126

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

fieldofnodes
Copy link
Contributor

Per the conversation in #1118

I have added the line

animalcolor(animal) = animalcolor(animal, variant(animal))

@Datseris Datseris merged commit 2f533eb into JuliaDynamics:main Jan 18, 2025
5 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (8b5b456) to head (dd04e98).
Report is 165 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1126       +/-   ##
===========================================
+ Coverage   70.12%   85.00%   +14.87%     
===========================================
  Files          42       37        -5     
  Lines        2718     2534      -184     
===========================================
+ Hits         1906     2154      +248     
+ Misses        812      380      -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tortar
Copy link
Member

Tortar commented Jan 18, 2025

mmh, it doesn't seem correct, I didn't run the code, but shouldn't it be

animalcolor(animal) = animalcolor(variant(animal))

?

@Datseris
Copy link
Member

oh yeah... I didn't look at the code, it was a mistake from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants