DocMeta: Access META binding through invokelatest
#2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in Julia 1.12, global bindings have strict world-age semantics so this change is required to avoid the warning introduced by JuliaLang/julia#57133
topolarity
force-pushed
the
ct/binding-worldage
branch
from
ac3d1de to
120183c
Compare
|
I'm really not sure why this is causing: PR #1634, issue #1655: Test Failed at /home/runner/work/Documenter.jl/Documenter.jl/test/utilities.jl:390
Expression: (exs[1])[2] == "1 + 1\n# comment\n\n"
Evaluated: "1 + 1\n" == "1 + 1\n# comment\n\n"on nightly |
|
Ah, that's most likely an unrelated problem due to JuliaLang/julia#57280 |
|
Thank you @topolarity (and @lgoettgens) ! I was wondering about the |
This was referenced Feb 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Julia 1.12, global bindings have strict world-age semantics so this change is required to avoid the warning introduced by JuliaLang/julia#57133
Resolves #2621. This replaces #2622, which took things in the right direction but was missing a few required
invokelatestClose #2621, close #2622.