Import stage2 demand-driven forward mode #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports a ripped-out version of the demand-driven AD code from CedarSim and hooks it into the ADInterpreter. Starting with this code has the advantage that it is working-ish, but the disadvantage that it doesn't really interact with the rest of Diffractor yet. Still, I think it's a reasonable point to start. I'm doing this as a separate commit, so we can keep better track of the subsequent refactoring.
Codecov ReportBase: 50.21% // Head: 52.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 50.21% 52.68% +2.47%
==========================================
Files 23 27 +4
Lines 2350 2513 +163
==========================================
+ Hits 1180 1324 +144
- Misses 1170 1189 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports a ripped-out version of the demand-driven AD code from CedarSim and hooks it into the ADInterpreter. Starting with this code has the advantage that it is working-ish, but the disadvantage that it doesn't really interact with the rest of Diffractor yet. Still, I think it's a reasonable point to start. I'm doing this as a separate commit, so we can keep better track of the subsequent refactoring.