Mark tests broken based on nightly #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 51.41% 53.89% +2.47%
==========================================
Files 21 21
Lines 2118 2171 +53
==========================================
+ Hits 1089 1170 +81
+ Misses 1029 1001 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mcabbott
commented
Aug 27, 2022
| @@ -16,6 +16,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| version: | |||
| - '1.7' # Lowest claimed support in Project.toml | |||
There was a problem hiding this comment.
Test failures on 1.8 look like this, so perhaps it should run on 1.7 too:
┌ Warning: ir verification broken. Either use 1.9 or 1.7
└ @ Diffractor ~/work/Diffractor.jl/Diffractor.jl/src/stage1/recurse.jl:889
┌ Warning: ir verification broken. Either use 1.9 or 1.7
└ @ Diffractor ~/work/Diffractor.jl/Diffractor.jl/src/stage1/recurse.jl:889
Error During Test at /home/runner/work/Diffractor.jl/Diffractor.jl/test/runtests.jl:23
Test threw exception
Expression: tup2(my_tuple) == (ZeroTangent(), 4)
task switch not allowed from inside staged nor pure functions
Stacktrace:
[1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
@ Base ./task.jl:861
[2] wait()
@ Base ./task.jl:931
[3] uv_write(s::Base.PipeEndpoint, p::Ptr{UInt8}, n::UInt64)
@ Base ./stream.jl:1043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes nothing, but marks as broken the tests which don't pass on Julia nightly (1.9) and latest everything.