Fix tests #62
Fix tests #62
Conversation
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 57.04% 57.08% +0.04%
==========================================
Files 21 21
Lines 2158 2158
==========================================
+ Hits 1231 1232 +1
+ Misses 927 926 -1
Continue to review full report at Codecov.
|
| @@ -148,7 +150,7 @@ end | |||
| @test gradient(x -> sum(abs2, x .+ 1.0), zeros(3))[1] == [2.0, 2.0, 2.0] | |||
|
|
|||
| const fwd = Diffractor.PrimeDerivativeFwd | |||
| const bwd = Diffractor.PrimeDerivativeFwd | |||
| const bwd = Diffractor.PrimeDerivativeBack | |||
test/runtests.jl
Outdated
| # Higher order control flow not yet supported | ||
| @test_broken (x->x^5)'''(1.0) == 60. |
There was a problem hiding this comment.
| # Higher order control flow not yet supported | |
| @test_broken (x->x^5)'''(1.0) == 60. | |
| @test (x->(x*x)*(x*x)*x)''' == 60. | |
| # Higher order control flow not yet supported (https://github.com/JuliaDiff/Diffractor.jl/issues/24) | |
| @test_broken (x->x^5)'''(1.0) == 60. |
There was a problem hiding this comment.
Mind if I commit this and merge?
There was a problem hiding this comment.
It was green before! Now fails at a line outside suggestion box range.
There was a problem hiding this comment.
That line tests inference quality. Since CI is running nightly, that might have regressed. I think it's fine to merge anyway, and we'll go back and fix it.
| # Error: ArgumentError: Tangent for the primal Tangent{Tuple{Float64, Float64}, Tuple{Float64, Float64}} | ||
| # should be backed by a NamedTuple type, not by Tuple{Tangent{Tuple{Float64, Float64}, Tuple{Float64, Float64}}}. |
There was a problem hiding this comment.
JuliaDiff/ChainRulesCore.jl#503 should address this, but the integration test still seems to be failing. Probably fine mark these as broken for now, until I figure that out.
|
should this be merged? |
Co-authored-by: Simeon Schaub <[email protected]>
I played around with Diffractor and fixed some issues with the tests. Unfortunately, I could not fix some of them.
const bwdis now backward mode not forwardtestfolder per Julia 1.2 Pkg manual