-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies and add compat #47
Conversation
simeonschaub
commented
Sep 10, 2021
- add compat entries
- update dependencies
# This file is machine-generated - editing it directly is not advised | ||
|
||
[[Adapt]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not new, but is it a good idea to check in the manifest?
Will this constrain CI to run these exact versions, or will it resolve to the latest allowed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CI will use these versions if possible. I believe the Manifest was originally checked in because Diffractor depended on different branches of some dependencies, but I don't think that's the case anymore. @Keno, should we just delete the Manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll merge this as-is and then we can revisit whether we want to just delete the manifest later.
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage ? 55.67%
=======================================
Files ? 21
Lines ? 2098
Branches ? 0
=======================================
Hits ? 1168
Misses ? 930
Partials ? 0 Continue to review full report at Codecov.
|