Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and add compat #47

Merged
merged 3 commits into from
Sep 10, 2021
Merged

update dependencies and add compat #47

merged 3 commits into from
Sep 10, 2021

Conversation

simeonschaub
Copy link
Member

  • add compat entries
  • update dependencies

Project.toml Outdated Show resolved Hide resolved
Comment on lines 1 to -3
# This file is machine-generated - editing it directly is not advised

[[Adapt]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new, but is it a good idea to check in the manifest?

Will this constrain CI to run these exact versions, or will it resolve to the latest allowed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CI will use these versions if possible. I believe the Manifest was originally checked in because Diffractor depended on different branches of some dependencies, but I don't think that's the case anymore. @Keno, should we just delete the Manifest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll merge this as-is and then we can revisit whether we want to just delete the manifest later.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c5c54f8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage        ?   55.67%           
=======================================
  Files           ?       21           
  Lines           ?     2098           
  Branches        ?        0           
=======================================
  Hits            ?     1168           
  Misses          ?      930           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c54f8...1104030. Read the comment docs.

@simeonschaub simeonschaub merged commit b03feac into main Sep 10, 2021
@simeonschaub simeonschaub deleted the sds/compat branch September 10, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants