Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to Cthulhu API change #268

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Adjust to Cthulhu API change #268

merged 1 commit into from
Feb 13, 2024

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Feb 12, 2024

No description provided.

@Keno Keno requested a review from aviatesk February 12, 2024 20:57
@oxinabox
Copy link
Member

This change was made in JuliaDebug/Cthulhu.jl#522
v"2.10.1" was the first release after that, do we need to add such a lower bound on Cthulhu ?

aviatesk
aviatesk approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1 for @oxinabox 's suggestion.

@oscardssmith oscardssmith merged commit b21efef into main Feb 13, 2024
3 checks passed
@oscardssmith oscardssmith deleted the kf/cthulhuexct branch February 13, 2024 04:11
oxinabox added a commit that referenced this pull request Feb 13, 2024
@oxinabox
Update cthulhu bounds after #268
b37f585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keno @oxinabox @aviatesk @oscardssmith