Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add truncate for explicit tangent #215

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

pepijndevos
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (3b4e59f) 55.09% compared to head (a39ef12) 55.03%.
Report is 1 commits behind head on main.

❗ Current head a39ef12 differs from pull request most recent head ee36daa. Consider uploading reports for the commit ee36daa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   55.09%   55.03%   -0.06%     
==========================================
  Files          28       28              
  Lines        2797     2800       +3     
==========================================
  Hits         1541     1541              
- Misses       1256     1259       +3     
Files Changed Coverage Δ
src/tangent.jl 51.12% <0.00%> (-1.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Member

This seems right to me, can we just add some unit tests?
like just directly calling the method.

@pepijndevos
Copy link
Contributor Author

done

@oxinabox oxinabox merged commit ee8af85 into JuliaDiff:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants