Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getindex definition on 1.11 #203

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

oscardssmith
Copy link
Member

We recently defined this in Base.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (9b2a506) 55.01% compared to head (74d5208) 54.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   55.01%   54.96%   -0.06%     
==========================================
  Files          28       28              
  Lines        2790     2791       +1     
==========================================
- Hits         1535     1534       -1     
- Misses       1255     1257       +2     
Files Changed Coverage Δ
src/stage1/compiler_utils.jl 95.45% <100.00%> (ø)
src/stage1/recurse.jl 96.90% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscardssmith
Copy link
Member Author

@Keno do you understand why macos CI is failing but linux ci is working?

@oscardssmith oscardssmith merged commit 8dd45c0 into JuliaDiff:main Aug 16, 2023
@oscardssmith oscardssmith deleted the fix-on-master branch August 16, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant