Ignore :boundscheck and :code_coverage_effect IR nodes
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Jun 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 52.29% 52.29%
=======================================
Files 27 27
Lines 2719 2719
=======================================
Hits 1422 1422
Misses 1297 1297
☔ View full report in Codecov by Sentry. |
Keno
reviewed
Jun 29, 2023
| @@ -53,7 +53,8 @@ function fwd_transform!(ci, mi, nargs, N) | |||
| return ZeroBundle{N}(mi.sparam_vals[stmt.args[1]::Int]) | |||
| elseif isexpr(stmt, :foreigncall) | |||
| return Expr(:call, error, "Attempted to AD a foreigncall. Missing rule?") | |||
| elseif isexpr(stmt, :meta) || isexpr(stmt, :inbounds) || isexpr(stmt, :loopinfo) | |||
| elseif isexpr(stmt, :meta) || isexpr(stmt, :inbounds) || isexpr(stmt, :loopinfo) || | |||
| isexpr(stmt, :boundscheck) || isexpr(stmt, :code_coverage_effect) | |||
There was a problem hiding this comment.
Expr(:boundscheck) returns a bool, so this is incorrect.
There was a problem hiding this comment.
Fixed (and test added) in #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.