Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reverse mode #175

Merged
merged 3 commits into from
Jun 29, 2023
Merged

fix reverse mode #175

merged 3 commits into from
Jun 29, 2023

Conversation

oscardssmith
Copy link
Member

This already has the error count down to 16 (from 47). The remaining issues appear to all be keyword related

@oscardssmith oscardssmith requested a review from Keno June 28, 2023 20:21
@Keno Keno force-pushed the fix-reverse-mode branch from 65f11be to 91cda3d Compare June 29, 2023 14:38
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +29.31 🎉

Comparison is base (096f918) 22.98% compared to head (91cda3d) 52.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #175       +/-   ##
===========================================
+ Coverage   22.98%   52.29%   +29.31%     
===========================================
  Files          27       27               
  Lines        2676     2719       +43     
===========================================
+ Hits          615     1422      +807     
+ Misses       2061     1297      -764     
Impacted Files Coverage Δ
src/codegen/reverse.jl 92.89% <100.00%> (+92.89%) ⬆️
src/stage1/recurse.jl 96.41% <100.00%> (+84.10%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keno Keno merged commit cab3a49 into main Jun 29, 2023
@oscardssmith oscardssmith deleted the fix-reverse-mode branch June 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants