bipass all Diffractor machinery if there are no partials #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 22.99% 22.96% -0.04%
==========================================
Files 27 27
Lines 2666 2674 +8
==========================================
+ Hits 613 614 +1
- Misses 2053 2060 +7
☔ View full report in Codecov by Sentry. |
staticfloat
approved these changes
Jun 28, 2023
Comment on lines
+146
to
+150
| function (::∂☆internal{1})(f::AbstractZeroBundle{1}, args::AbstractZeroBundle{1}...) | ||
| f_v = primal(f) | ||
| args_v = map(primal, args) | ||
| return ZeroBundle{1}(f_v(args_v...)) | ||
| end |
There was a problem hiding this comment.
Why do you have a special case for order 1?
oscardssmith
approved these changes
Jun 28, 2023
|
I think this makes sense, so I'm just going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the recent work by @Keno and @staticfloat.
By the linearity of the derivative operation if the inputs are all zero so is the output.
A case can be made that we actually should be still invoking the
frules for this path.But I am not sure that's a good argument.
Here the derivative isn't just
iszeroit has been put into the types it is zero and can't ever not be zero.(This would not for example be the case if it were being mutated)