remove :loopinfo from IR #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 51.48% 51.48% -0.01%
==========================================
Files 27 27
Lines 2694 2696 +2
==========================================
+ Hits 1387 1388 +1
- Misses 1307 1308 +1
☔ View full report in Codecov by Sentry. |
Keno
reviewed
May 23, 2023
| @@ -185,6 +185,8 @@ function forward_visit!(ir::IRCode, ssa::SSAValue, order::Int, ssa_orders::Vecto | |||
| recurse(stmt) | |||
| elseif isexpr(stmt, :code_coverage_effect) | |||
| return | |||
| elseif isexpr(stmt, :loopinfo) #TODO preserve this properly | |||
There was a problem hiding this comment.
It can't be outright preserved but we might be able to do something with this infromation
Keno
reviewed
May 23, 2023
| # Can't trust that meta annotations are still valid in the AD'd | ||
| # version. | ||
| return nothing | ||
| else | ||
| #TODO put guard here. We really don't want invalid IR |
There was a problem hiding this comment.
This is not in general invalid IR
There was a problem hiding this comment.
The proposal here is rather that we assert that this is only getting various kinds of literals to wrap in a ZeroBundle (be they functions or numbers etc)
and if not give a good error message, rather than generating invalid IR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
Diffractor.PrimeDerivativeFwd(x->prod([x, 4]))(3). (with help from @oxinabox)