Forward mode handingly for Expr(:new, ) in forward_diff_no_inf!
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oxinabox can you make test for this please? |
Keno
reviewed
May 17, 2023
staticfloat
force-pushed
the
sf/fix_new_zero_bundle_error
branch
from
a9df060 to
0a3e34a
Compare
Keno
approved these changes
May 17, 2023
oxinabox
changed the title
Expr(:new, ) in forward_diff_no_inf!Expr(:new, ) in forward_diff_no_inf!
oxinabox
reviewed
May 17, 2023
Comment on lines
+54
to
+57
| identity_transform!(ir, ssa::Core.SSAValue, order) = ir[ssa] | ||
| function identity_transform!(ir, arg::Core.Argument, order) | ||
| return Core.Compiler.insert_node!(ir, Core.SSAValue(1), Core.Compiler.NewInstruction(Expr(:call, Diffractor.ZeroBundle{1}, arg), Any)) | ||
| end |
There was a problem hiding this comment.
@Keno it seems that this is always required.
Frames and I tracked down an issue where the type argument to an `Expr(:new, )` (argument #1) was getting wrapped in a `ZeroBundle`. This commit adds a special-case for `Expr(:new, )` into `forward_diff_no_inf!()` that mimics what we see elsewhere, making use of `∂☆new`.
oxinabox
force-pushed
the
sf/fix_new_zero_bundle_error
branch
from
501300b to
f52c853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frames and I tracked down an issue where the type argument to an
Expr(:new, )(argument #1) was getting wrapped in aZeroBundle. This commit adds a special-case forExpr(:new, )intoforward_diff_no_inf!()that mimics what we see elsewhere, making use of∂☆new.